search

wicketstuff / core

Wicketstuff-core projects are bundled user contributions for use with Apache Wicket (https://wicket.apache.org/). They are released in step with Wicket releases to make them easy to use.
342 stars 298 forks source link

inmethod datagrid is not ready for use with JavascriptFilteredIntoFooterHeaderResponse #32

Closed shuraa closed 13 years ago

shuraa commented 13 years ago

I have using JavascriptFilteredIntoFooterHeaderResponse strategy for rendering javascript on my sites. Now I have looking for ways to integrate inmethod DataGrid component and have stuck with javascript initialization issue - in javascript console I've got "Uncaught ReferenceError: InMethod is not defined" on line "InMethod.XTableManager.instance.register("gride", columns, submitStateCallback);". Is there workaround for the issue ?

Env: Wicket 1.4.17, inmethod-grid-1.4.17.1, JDK 1.6u25, Jetty 6

Thank you, Alexander.

martin-g commented 13 years ago

If you provide a quickstart then the chance someone to try to debug and improve it will be higher. Otherwise since wicketstuff is community based most probably no one will look into this issue until (s)he face the same problem in his/her application. It shouldn't be a problem to debug it yourself - just find where "InMethod.XTableManager.instance.register" is being called and change the method that renders it to a one that is filtered.

shuraa commented 13 years ago

Martin, I'm not very familiar with github. Please, point me where I can read about attaching quickstart and proposed patch to the issue ?

akiraly commented 13 years ago

I do not know about a way to attach files to an issue but you could create a git repository and put the quickstart there. After that you can link the repo to this issue.

shuraa commented 13 years ago

Ok, I've created a quickstart and publish it on github https://github.com/shuraa/wicketstuff-inmethod-datagrid-issue32

Later I'll add a patch for the issue.

shuraa commented 13 years ago

Please, review and apply patch https://github.com/shuraa/wicketstuff-inmethod-datagrid-issue32/blob/master/wicketstuff-core-issue32.patch

martin-g commented 13 years ago

The patch looks OK. I'll test it soon and apply it. Unless someone else do it before me.

akiraly commented 13 years ago

I have ported shuraa's quickstart to wicket+wicketsuff 1.5 and the issue (js error) is present there too.

shuraa commented 13 years ago

Patch was merged to core-1.4.x and master. Thanks to everybody!