search

wicketstuff / core

Wicketstuff-core projects are bundled user contributions for use with Apache Wicket (https://wicket.apache.org/). They are released in step with Wicket releases to make them easy to use.
340 stars 297 forks source link

DatePicker: getting few HTTP 404 errors if locale is en_US #434

Open azakhark opened 8 years ago

azakhark commented 8 years ago

If locale is en_US and page has instance of DatePicker, I see HTTP 404 errors for following resources:

And following warnings in log file:

WARN  - PackageResource            - resource [path = org/wicketstuff/jwicket/ui/datepicker/jquery.ui.datepicker-en.js, style = null, variation = null, locale = null]: Unable to find resource (status=404)
WARN  - PackageResource            - resource [path = org/wicketstuff/jwicket/ui/datepicker/css/jquery.ui.base.css, style = null, variation = null, locale = null]: Unable to find resource (status=404)
iamrakesh commented 8 years ago

Issue with 404 for jquery.ui.datepicker-en.js seems to be due to https://bugs.jqueryui.com/ticket/6682 And 404 for jquery.ui.base.css, is possibly due to a typo at line#1612 in DatePicker.java.

new JQueryCssResourceReference(DatePicker.class, "css/jquery.ui.base.css") should be new JQueryCssResourceReference(DatePicker.class, "css/jquery.ui.core.css")

martin-g commented 8 years ago

Please create a Pull Request for the second issue! For the first issue I guess we need to update the version of jQuery UI ?! Thank you!

iamrakesh commented 8 years ago

Yes, Updating JQuery Ui version should fix the 404 for jquery.ui.datepicker-en.js. PR to fix CSS 404 is https://github.com/wicketstuff/core/pull/449