search

wicketstuff / core

Wicketstuff-core projects are bundled user contributions for use with Apache Wicket (https://wicket.apache.org/). They are released in step with Wicket releases to make them easy to use.
340 stars 297 forks source link

First release with Wicket 10? #752

Closed ilgrosso closed 1 year ago

ilgrosso commented 1 year ago

Now that Wicket 10.0.0-M1 is out, any chance to cut a relase from the master branch here?

solomax commented 1 year ago

I can create release in a couple of weeks Currently on vacation :))

ilgrosso commented 1 year ago

Sure, thank you @solomax !

reiern70 commented 1 year ago

Maybe some of the other wicket developers should also have credentials to do this? So, that we are not blocked by a single person?

On Thu, Jun 29, 2023 at 7:43 AM Francesco Chicchiriccò < @.***> wrote:

Sure, thank you @solomax https://github.com/solomax !

— Reply to this email directly, view it on GitHub https://github.com/wicketstuff/core/issues/752#issuecomment-1612422237, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQ6PZXE5IYOMAJ4VAREYTXNUBWPANCNFSM6AAAAAAZWVEDJQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Regards - Ernesto Reinaldo Barreiro

martin-g commented 1 year ago

@reiern70 Do you volunteer ? :-) Several other devs have the credentials but lack the time and/or desire.

reiern70 commented 1 year ago

@reiern70 Do you volunteer ? :-) Several other devs have the credentials but lack the time and/or desire.

Yes. This week I can do :-)

reiern70 commented 1 year ago

@reiern70 Do you volunteer ? :-) Several other devs have the credentials but lack the time and/or desire.

This is perfectly understandable. I think only other fellow open source developers can understand this. And again many thanks to all of you for the countless hours you have spent away from family fixing problems for people (companies) that many times do not properly say thanks! More and more I'm convinced that people do not value what they get for free and no efforts ;-) And I;m refering not only to software

martin-g commented 1 year ago

I haven't released Wicketstuff core in many years but you could try with:

JAVA_HOME=$JAVA_17_HOME mvn clean release:clean release:prepare release:perform -Dgpg.passphrase=YOUR_GPG_PASS_PHRASE
solomax commented 1 year ago

No need to specify java-home :) Toolchain will select correct version :)

Release process is described here: https://github.com/wicketstuff/core/wiki/Wicket-Stuff-Core-Release-Process

bitstorm commented 1 year ago

On Thu, Jun 29, 2023 at 8:45 AM Ernesto Reinaldo Barreiro < @.***> wrote:

@reiern70 https://github.com/reiern70 Do you volunteer ? :-) Several other devs have the credentials but lack the time and/or desire.

This is perfectly understandable. I think only other fellow open source developers can understand this. And again many thanks to all of you for the countless hours you have spent away from family fixing problems for people (companies) that many times do not properly say thanks! More and more I'm convinced that people do not value what they get for free and no efforts ;-) And I;m refering not only to software

🙏❤

— Reply to this email directly, view it on GitHub https://github.com/wicketstuff/core/issues/752#issuecomment-1612508642, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDCUDA6DVY5BFA2RV65W3XNUP6PANCNFSM6AAAAAAZWVEDJQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Andrea Del Bene. Apache Wicket committer.

solomax commented 1 year ago

Hello All

I'm back :)))

It seem there is a blocker for this release: <wicket-webjars.version>4.0.0-SNAPSHOT</wicket-webjars.version>

@martin-g maybe you can release wicket-webjars :)))

martin-g commented 1 year ago

Doing it!

martin-g commented 1 year ago

Done!

solomax commented 1 year ago

not listed here https://repo1.maven.org/maven2/de/agilecoders/wicket/webjars/wicket-webjars/ yet ... :((( I'll wait

solomax commented 1 year ago

Another blocker seems to be: ./portlet-parent/wicketstuff-portlet/pom.xml

                <dependency>
                        <!-- FIXME TODO temporary, wicket version doesn't have `portlet` -->
                        <groupId>org.apache.commons</groupId>
                        <artifactId>commons-fileupload2</artifactId>
                        <version>2.0-SNAPSHOT</version>
                        <exclusions>
                                <exclusion>
                                        <groupId>javax.portlet</groupId>
                                        <artifactId>portlet-api</artifactId>
                                </exclusion>
                        </exclusions>
                </dependency>

I'm afraid the only option here is to wait for commons-fileupload :(

hopefully it will be released this week ..... :(

Alternatively I can turn off portlet-parent for M1 ....

WDYT?

martin-g commented 1 year ago

Alternatively I can turn off portlet-parent for M1 ....

Does anyone still use Portlets ?!

solomax commented 1 year ago

To be fair I have no idea what portlets is :)))

Are you proposing to drop them from master all-together?

martin-g commented 1 year ago

I'm 99.9% certain no one would complain about it!

solomax commented 1 year ago

OK :) Let's drop it :)))

solomax commented 1 year ago

I'm going to create release notes using git shortlog -n wicketstuff-core-9.14.0..wicketstuff-core-10.0.0-M1

Is this OK?

martin-g commented 1 year ago

Yes!

reckart commented 1 year ago

@solomax do you know the release notes generation feature in GitHub itself?

solomax commented 1 year ago

@reckart no :) I'm following release process as described in wiki :)

BTW most changes are done without PR or GH issue, so they will not get into generated notes ....

reckart commented 1 year ago

Yea... when using PRs consistently, GitHub can actually generate quite nice release notes. I'm using that nowadays quite happily for my release notes needs ;)