#933 Use Webjars for JQuery UI themes

wicketstuff / core

Wicketstuff-core projects are bundled user contributions for use with Apache Wicket (https://wicket.apache.org/). They are released in step with Wicket releases to make them easy to use.

336 stars 299 forks source link

#933 Use Webjars for JQuery UI themes #934

Closed mcr-paulanand closed 1 month ago

mcr-paulanand commented 1 month ago

Resolves #933

solomax commented 1 month ago

I believe this PR should be closed and shouldn't be merged

you are replacing customized themed CSS with the default one ...

this will effectively ruin theming :(

reckart commented 1 month ago

The Webjars install in this PR seems to be essential for me, otherwise my app won't start (i.e. with the 10.1.0 release, it won't start).

solomax commented 1 month ago

@reckart I believe you need to add 'install' to your app's 'init'

I'll try to check this branch locally and will report back

reckart commented 1 month ago

The init method runs after the SPI-injected initializers and the theme initializer already triggers a webjar access.

solomax commented 1 month ago

The init method runs after the SPI-injected initializers and the theme initializer already triggers a webjar access.

I did some testing:

clone repo for this PR
build 51 subproject of wicket-jquery-ui
cd wicketstuff-jquery-ui-samples
change the theme to be wicketstuff-jquery-ui-theme-eggplant
run samples Result: theme remain the same
Tested the release with the same steps Result: Samples were not started

My conclusion: WicketWebjars.install((WebApplication)application); MUST be added to all Initializers

This PR: shouldn't be merged as-is ...

New release seems to be required :(

solomax commented 1 month ago

I can create alternative pr for review later today :)

solomax commented 1 month ago

I can create alternative pr for review later today :)

Done: https://github.com/wicketstuff/core/pull/935 :)))

reckart commented 1 month ago

Ok, so we can close this one. Thanks @mcr-paulanand @solomax !