search

wicketstuff / core

Wicketstuff-core projects are bundled user contributions for use with Apache Wicket (https://wicket.apache.org/). They are released in step with Wicket releases to make them easy to use.
343 stars 298 forks source link

[jquery-ui] conflicting webjar #954

Open solomax opened 5 months ago

solomax commented 5 months ago

Our project uses both wicketstuff-jquery-ui and wicket-bootstrap

one of them uses

[INFO] +- org.wicketstuff:wicketstuff-jquery-ui-core:jar:10.1.1:compile
[INFO] |  \- org.webjars.npm:moment:jar:2.30.1:compile

the other one uses:

[INFO] +- de.agilecoders.wicket:wicket-bootstrap-extensions:jar:7.0.5:compile
[INFO] |  +- org.webjars:momentjs:jar:2.29.4:compile

So I got 2 versions of momenjs same time

Webjars is unable to work in such situation

IMO these versions should be aligned @martin-g WDYT should I update wicketstuff or wicket-bootstrap?

reckart commented 5 months ago

Why does Maven not resolve this to the latest (closest) version?

reckart commented 5 months ago

Ah - different groupIDs. It would be good to align the groupIDs.

solomax commented 5 months ago

both groupId and artifactId differs :(

martin-g commented 5 months ago

IMO these versions should be aligned @martin-g WDYT should I update wicketstuff or wicket-bootstrap?

Honestly I have no idea what is the difference between those two ways of packaging ...

If both work for our needs then I'd suggest to use the dependency that is newer, i.e. (org.webjars.npm:moment:jar:2.30.1).

solomax commented 5 months ago 
GroupID = org.webjars
ArtifactID = momentjs
Version = 2.30.1

was just generated and deployed :)))

I'll update wicketstuff-core to be aligned with wicket-bootstrap (also need to fix some other issues :)))

solomax commented 5 months ago

Unfortunately this fix should be reverted :(

For whatever reason org.webjars:momentjs doesn't contains required files :(

I'll create PR for wicket-bootstrap