search

wickman / pystachio

type-checked dictionary templating library for python
MIT License
91 stars 22 forks source link

Fix Map comparison under pypy. #14

Closed jsirois closed 8 years ago

jsirois commented 9 years ago

Previously Map indirectly relied on dict iteration order in its eq implementation and this blew up under pypy. Now Map uses the same stable comparison structure returned by get() as it uses in its hash which has the side-benefit of being easier to reason about; ie: the hash and == relationship is now more obviously sane.

jsirois commented 9 years ago

NB: 1st commit failed like so on my machine and under travis: https://travis-ci.org/jsirois/pystachio/jobs/54761346 Second commit goes green: https://travis-ci.org/jsirois/pystachio/builds/54762436

jsirois commented 8 years ago

Ok, rebasing made it clear a similar .travis.yml commit was done - its here: https://github.com/wickman/pystachio/commit/76fbf759638d9af549717e95188b7fe90edd37da Ditto a fix for the pypy issue, here: https://github.com/wickman/pystachio/commit/819c893f4670bc20a3d67396904d94740050dd59

I'll close this PR and mint a new one that just expands .travis.yml coverage.