search

wickram / intro-data-capstone-biodiversity

0 stars 0 forks source link

(Summary) Needs work #6

Open CharlesDLandau opened 6 years ago

CharlesDLandau commented 6 years ago

You're off to a good start! You've got pretty clean code, and an attractive presentation. The two big problems here are: 1) incorrect terms/unclear language in the presentation and 2) no comments in your code. Having comments in your code is absolutely essential for readability, and if your findings aren't communicated clearly then all our work coding may be for nothing.

In terms of next steps once you fix that, I would definitely recommend reviewing PEPs 8 and 20. If you want to take another crack at a full project, I don't think there's any rule against trying the other capstone.

wickram commented 6 years ago

Hi Charles, Thanks for reviewing this. I did all the changes suggested by you and updated both the code and presentation again. Please review it and share your feedback

CharlesDLandau commented 6 years ago

Yes greatly improved by those changes, I think.

On Sun, Feb 18, 2018 at 10:40 AM wickram notifications@github.com wrote:

Hi Charles, Thanks for reviewing this. I did all the changes suggested by you and updated both the code and presentation again. Please review it and share your feedback

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wickram/intro-data-capstone-biodiversity/issues/6#issuecomment-366524743, or mute the thread https://github.com/notifications/unsubscribe-auth/AZwyzvgoO9j95VWuXJRPeMsnVac21ftaks5tWERugaJpZM4SJYG5 .

wickram commented 6 years ago

Awesome, Thanks. So what are the next steps to get my credential?