Closed sportlabsMike closed 6 years ago
Hi,
I noticed that all the GetSetClassTests were failing on Linux. After a bit of digging I found it was due to an incorrect definition of Kind. See https://github.com/apple/swift/blob/master/include/swift/ABI/MetadataKind.def and https://github.com/Zewo/Reflection/blob/master/Sources/Reflection/Metadata%2BKind.swift
GetSetClassTests
Kind
This pull request fixes Kind and configures travis to run test on both macOS and linux.
This fix will fix the following PR https://github.com/GraphQLSwift/GraphQL/pull/38
@sportlabsMike thanks for this! 👍
Looks good thanks!
Hi,
I noticed that all the
GetSetClassTests
were failing on Linux. After a bit of digging I found it was due to an incorrect definition ofKind
. See https://github.com/apple/swift/blob/master/include/swift/ABI/MetadataKind.def and https://github.com/Zewo/Reflection/blob/master/Sources/Reflection/Metadata%2BKind.swiftThis pull request fixes
Kind
and configures travis to run test on both macOS and linux.This fix will fix the following PR https://github.com/GraphQLSwift/GraphQL/pull/38