search

wicol / unifi-dns

A dnsmasq being populated by aliases/name overrides made in a UniFi controller
MIT License
45 stars 10 forks source link

Add a check for ip presence in active clients #1

Closed mattrayner closed 5 years ago

mattrayner commented 5 years ago

There is an edge case where some virtual interfaces will not be assigned an IP. In that instance, the script errors. Instead, we should ignore them because they will not originate traffic and are not routable.

mattrayner commented 5 years ago

@wicol I was wondering if you had a chance to take a look at this? It's blocking my deployment of this at the moment :(

wicol commented 5 years ago

Oh sorry, didn't get notified for the PR but did for the mention. LGTM.

mattrayner commented 5 years ago

Thanks @wicol, let me know when you've updated the docker hub image - great project :+1:

wicol commented 5 years ago

@mattrayner its automated so you're good to go. Just do a pull :)

mattrayner commented 5 years ago

Amazing, it works perfectly!

On Thu, 30 May 2019 at 13:15, Wictor notifications@github.com wrote:

@mattrayner https://github.com/mattrayner its automated so you're good to go. Just do a pull :)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/wicol/unifi-dns/pull/1?email_source=notifications&email_token=AA2XGNVAGX4RRH5K2FF5ZCLPX7AOFA5CNFSM4HQEZ4S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWSFOWY#issuecomment-497309531, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2XGNS5TVNWEK6D6YQ6HATPX7AOFANCNFSM4HQEZ4SQ .

-- Matt Rayner http://www.mattrayner.co.uk/