wics-uw / website

The code that runs http://wics.uwaterloo.ca/
Other
9 stars 49 forks source link

Code party #138

Closed andeeliao closed 8 years ago

andeeliao commented 8 years ago

Event page for code party

ehashman commented 8 years ago

Please rebase your commits, you have extraneous merges.

ehashman commented 8 years ago

Less the comments, LGTM. Will need to fix the git problems before this is mergeable though.

ehashman commented 8 years ago

Okay, if you insist on closing this pull request, please run the following commands (assuming you've set up your repo like I suggested in the README):

git checkout master
git fetch upstream
git rebase upstream/master
git checkout -b code-party-secondattempt
git cherry-pick 80b5d49
git push origin HEAD
andeeliao commented 8 years ago

Hey Elana,

I tried those commands but am still having the same problem. It seems that when I fetch upstream, rebase and checkout my master branch still has the extraneous commits... not sure how to fix this :S the secondattempt still has the commits from september

fboxwala commented 8 years ago

Hey Andee, wanna try this instead:

git reset --hard 118ebcb git fetch upstream git rebase upstream/master git push --force origin HEAD

ehashman commented 8 years ago

+1 to Fatema's instructions. I didn't realize that your master itself had the merge problem, which means you'll need to reset that in addition to this branch!

andeeliao commented 8 years ago

Hmm, it still shows that I'm 1 commit ahead on my master branch. I checkout'd master before I applied Fatema's instructions, not sure if that makes a difference.

ehashman commented 8 years ago

Please hop on IRC so we can pair on this!

andeeliao commented 8 years ago

Roger that!