search

wics-uw / website

The code that runs http://wics.uwaterloo.ca/
Other
9 stars 49 forks source link

adds to 'Auditing and logging' section #139

Closed fboxwala closed 8 years ago

fboxwala commented 8 years ago

Also I added 'the' before Mathematics 3 because I thought it sounded better.

fboxwala commented 8 years ago

I didn't mean for this to be in the PR but now it is is that okay?

ehashman commented 8 years ago

@fboxwala: it's cool. If you want to separate it, just checkout -b to copy this branch and then go back to it and do a hard reset to HEAD^ with a force push.

fboxwala commented 8 years ago

Eh I'll leave that in and remember for next time

ehashman commented 8 years ago

Hey Fatema, I gave your draft the review you requested. Please address feedback and I'll merge your next commit.

ehashman commented 8 years ago

Sorry for all the new comments, there were a few new typos and I had a bit more feedback.

fboxwala commented 8 years ago

I think it's all better now, lemme know if I should squash the commits

ehashman commented 8 years ago

Yeah please do. If you want to do it in two commits (one for the typos and one with the summary file), that's good too.

fboxwala commented 8 years ago

squashed.

ehashman commented 8 years ago

Ahh I couldn't understand why the commit structure wasn't what I asked for until I realized I said the wrong thing. When I said "the typos" I actually meant the ones in the MUA file, not my requested corrections.

As is, could you pretty please squash these into one commit? I will understand if you say no and/or yell at me for this, lol >.<

fboxwala commented 8 years ago

blergh

fboxwala commented 8 years ago

squashed