search

wics-uw / website

The code that runs http://wics.uwaterloo.ca/
Other
9 stars 49 forks source link

Fix spacing in CSS for lists #161

Closed ehashman closed 8 years ago

ehashman commented 8 years ago

For whatever reason, our CSS theming is a bit inconsistent. I commented on how this looks to be a problem in #115. This problem affects pages such as the Office Policy, and soon, the MUA Summary.

I believe the required fix is to add some margin to ul elements, to match that of p elements.

I think the rule change here is beginner-friendly, so please feel free to comment on here if you are interested in working on this and would like to pair or have me mentor.

SZain commented 8 years ago

I can see the spacing problem in Office Policy. I would like to fix this.

ehashman commented 8 years ago

Okay @SZain, do you understand the comments above? Would screenshots help?

SZain commented 8 years ago

Yes i did, but still sending screenshots would definitely help.

ehashman commented 8 years ago

I'm a bit busy this week so it will be hard for me to get around to it until maybe next Monday/Tuesday, is that okay?

SZain commented 8 years ago

yes that's fine.

SZain commented 8 years ago

I was waiting for the screenshots but anyways I have pulled the requests.

ehashman commented 8 years ago

Hi @SZain, I haven't seen a pull request. Sorry for not sending that to you; you should feel free to ping people, I just forgot about this issue.

Here is the screenshot:

screenshot at 2016-03-30 17 17 08

As you can see, spacing between headers and unordered lists is wrong.

evykassirer commented 8 years ago

@SZain are you still wanting to work on this?