search

wics-uw / website

The code that runs http://wics.uwaterloo.ca/
Other
9 stars 49 forks source link

Someone added Sponsorship and it broke the header #173

Closed ehashman closed 8 years ago

ehashman commented 8 years ago

Now Tags is on its own line again. Why wasn't this tested? This should be fixed ASAP.

fboxwala commented 8 years ago

Am attempting to fix this -- sorry pls dont take my access.

ehashman commented 8 years ago

This appears to have been fixed in #174 but now I don't believe it addresses the original ask, which was to visibly display sponsorship information on our website. Hiding it at the bottom of the FAQ likely is going to get you in trouble again. Can you put something in "About" at the very least? And possibly in the footer?

fboxwala commented 8 years ago

We can definitely do about and the footer. Is there a way to expand the header?

ehashman commented 8 years ago

We could, but it's getting kind of wide. I wonder if we could shrink the spacing between header stuff a tiny bit. Sample past PR: #10

fboxwala commented 8 years ago

I can mess around with it tomorrow and try some stuff

ehashman commented 8 years ago

Header was unbroken by #174 so this should be closed and other sponsorship stuff should be filed as a separate issue.