wics-uw / website

The code that runs http://wics.uwaterloo.ca/
Other
9 stars 49 forks source link

Adds info on code review, commit squashing, and avoiding git pull #236

Closed evykassirer closed 8 years ago

evykassirer commented 8 years ago

addresses #234 and a couple of other things missing from the README, and I added a table of contents!

I'd love to see comments from everyone active on committee, since these things I'm talking about are common mistakes and you reviewing it:

Reviewers:

claricen commented 8 years ago

Changes look good! Can't think of anything else atm

OOPS I just found a typo

evykassirer commented 8 years ago

sweet! thanks for taking a look and confirming my changes are what you were thinking of

techiechelle commented 8 years ago

It looks good 👍 Before line 145, Submitting Pull Request, could you make a reference to "Testing Locally"? When I did my first git contributions, I didn't read the whole instructions. I went step by step, and made a lot of errors which could have been avoided if I knew how to test the site locally. 😄

evykassirer commented 8 years ago

how's it look now @techiechelle ? would that have helped you?

fboxwala commented 8 years ago

I think this looks really good! Since you are already on a branch messing with the file - how would you feel about adding the link to the git/github workshop on L38

evykassirer commented 8 years ago

yeah!! great idea