Removed the calendar and made the volunteer page visible

wics-uw / website

The code that runs http://wics.uwaterloo.ca/

Other

9 stars 49 forks source link

Removed the calendar and made the volunteer page visible #264

Closed fat1996 closed 8 years ago

arshiamufti commented 8 years ago

why are there two pull requests? Leave this one open and close the second #263 since this one seems to have both your changes. You might also want to update the title of this pull request.
squash your two commits into one (documentation for doing this is in the README or just post in wics-sys if you're having trouble)

Also, in general it's a good idea to give your branches better names than task but this is fine for now.

fboxwala commented 8 years ago

@arshiamufti Actually I would say its pretty okay for this to be two commits, since @fat1996 is changing two files. Generally I like the rule to be "one file changed == one commit".

arshiamufti commented 8 years ago

Sounds good to me--go ahead and merge.

evykassirer commented 8 years ago

@fboxwala is it possible to change it so it doesn't say ehashman deployed?

evykassirer commented 8 years ago

@fat1996 you can see at https://wics-site-pr-264.herokuapp.com/ that the navbar still overflows (tags is on the next line) - you'll have to make the volunteer tab title shorter

annalorimer commented 8 years ago

"Volunteer" as the tab name should be fine

fat1996 commented 8 years ago

I've changed the tab name to just 'volunteer'.

evykassirer commented 8 years ago

love it 😍