wics-uw / website

The code that runs http://wics.uwaterloo.ca/
Other
9 stars 49 forks source link

rewords instructions to squash commits, addresses #253 #274

Closed arshiamufti closed 6 years ago

arshiamufti commented 7 years ago

I still have to fix the width of the text and fix some markdown syntax, but I'm making the pr now so we can talk about the content. Changes I've made are:

evykassirer commented 7 years ago

@fat1996 can you review this?

fat1996 commented 7 years ago

@evykassirer Sure! @arshiamufti there's a reference to squashing in the "Reviewing a Pull Request" section under "Commits" which hasn't been linked to the section yet.

evykassirer commented 7 years ago

Actually we can take out stuff about squashing? We can just do it when we merge now.

annalorimer commented 7 years ago

@evykassirer I think we should keep it in there since it's still part of the workflow (even if it is on merge). We can update it to reflect that it gets done on merge.