search

wics-uw / website

The code that runs http://wics.uwaterloo.ca/
Other
9 stars 49 forks source link

Adding a 'pushing commits' section in the README #314

Closed fat1996 closed 7 years ago

fat1996 commented 7 years ago

Could we add a small section for how to add commits after a pull request has been opened, since the instructions then become "git push origin branch-name" instead of "git push origin HEAD"? I feel this might be helpful, especially after there are changes requested on your PR.

annalorimer commented 7 years ago

@fat1996 why did you close this?

fat1996 commented 7 years ago

@annalorimer I felt this should be added for the wiki that was created for the git workshop instead of the README. I was following the instructions on the wiki, and I felt this was unclear. Should I reopen it? I do have some suggestions for the wiki.

annalorimer commented 7 years ago

@fat1996 Makes sense. You just need to leave a note explaining why issues get closed 😃 .