search

widberg / bgfx.cmake

https://github.com/bkaradzic/bgfx.cmake. Independently maintained CMake build scripts for bgfx. Released under public domain.
https://github.com/bkaradzic/bgfx.cmake
Creative Commons Zero v1.0 Universal
286 stars 254 forks source link

not removing the egl/ppapi gles2 contexts #10

Closed onqtam closed 7 years ago

onqtam commented 7 years ago

the egl context is required when building with emscripten for asm.js - and the contents of the 2 files are ifdef-ed anyway so there is no problem in compiling them for platforms which don't need them.

JoshuaBrookover commented 7 years ago

I believe I originally excluded them just to avoid the msvc linker warnings. I just noticed there's one for hmd_ovr too.

11>hmd_ovr.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library
11>glcontext_ppapi.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library
11>glcontext_egl.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library

I'm sure there's something we can key off of in cmake to remove the warnings, but I'll go ahead and pull this in and worry about that later. Thanks for testing that out!

onqtam commented 7 years ago

I remember silencing such warnings in my project like this: cmake and macro for manipulating linker flags

onqtam commented 7 years ago

btw I was thinking of submitting a PR soon with updated submodules - thanks for creating this project! I've gained good understanding of bgfx and its tools while reading through the cmake code here!

JoshuaBrookover commented 7 years ago

You're welcome. Glad you find it useful.

Updating the submodules shouldn't be a problem. I don't think any of the libraries have changed their build process lately.