Fixed: Enable DEBUG/CHECK/TRACE builds of bgfx wasn't actually working

widberg / bgfx.cmake

https://github.com/bkaradzic/bgfx.cmake. Independently maintained CMake build scripts for bgfx. Released under public domain.

https://github.com/bkaradzic/bgfx.cmake

Creative Commons Zero v1.0 Universal

286 stars 254 forks source link

Fixed: Enable DEBUG/CHECK/TRACE builds of bgfx wasn't actually working #17

Closed jaynus closed 6 years ago

jaynus commented 6 years ago

Debug/CHECK builds of bgfx were not straightforward with the current setup; bgfx relies on BX also being debug-enabled, while this only enabled it for BGFX and only in CMAKE Debug mode. You actually have to enable BX_TRACE in both bgfx and bx to actually get trace working. This was only adding it to bgfx, and only with CMAKE_BUILD_TYPE=Debug.

I Added BGFX_CONFIG_DEBUG cmake option to easily enable checked/trace builds in release mode so you don't get the overhead.

JoshuaBrookover commented 6 years ago

Thanks! I've been wanting to do something about this, as well.