Closed handsomematt closed 4 years ago
Great change 👌 This should also make it fairly simple to create a package on vcpkg
Great change 👌 This should also make it fairly simple to create a package on vcpkg
That's the plan!
I have previously tested these changes on Linux with them working perfectly, however I've not tested it on upstream in 4 months so would be great if someone could make sure it works.
Gave it a test on Windows 10 with MSVC 2019, and it works fine! 💯 Just called find_package
and added a cpp that simply calls bgfx::init()
. (This could probably be done on CI as well, to test the installing step.)
I manually applied https://github.com/widberg/bgfx.cmake/pull/80 for testing this, but that works as expected, too.
Modifies the installation slightly to generate a modern CMake configuration installation target that can be included in a project like so:
We also change the hard coded "bin", "lib", "include" paths to the CMAKE_INSTALL_BINDIR, CMAKE_INSTALL_LIBDIR, counterparts.
An example of the generated install directory:
An example of building both Debug/Release binaries on Windows:
Depends on #80 #81