Closed peterjc closed 7 years ago
I'm inclined not to put this in master.
master
1) mkpasswd is now installed on the VM (you were working on a previous version, where we were not expecting to have to create users), so https://github.com/widdowquinn/Teaching-IBioIC-Intro-to-Bioinformatics/pull/17/commits/6e935e177e7158dfd874584486ad0953377fdea3 is redundant. I think the appropriate place for this would be in a Dockerfile if we are to package the materials that way, in the future (which would be sensible, perhaps). 2) I want us to be able to create the users on the VM without also copying materials into their $HOME as in https://github.com/widdowquinn/Teaching-IBioIC-Intro-to-Bioinformatics/pull/17/commits/83986121e658bdeef80ab9fff5b5afb7daa7c110. If we copy materials across, we significantly bloat the virtual HD, with implications for our filehosting, and the ease of VM transfer. I would rather that we have a separate script to copy the materials/repo across users, than combining both actions.
mkpasswd
$HOME
Agreed, the changes merged in #18 take care of this and more.
I'm inclined not to put this in
master
.1)
mkpasswd
is now installed on the VM (you were working on a previous version, where we were not expecting to have to create users), so https://github.com/widdowquinn/Teaching-IBioIC-Intro-to-Bioinformatics/pull/17/commits/6e935e177e7158dfd874584486ad0953377fdea3 is redundant. I think the appropriate place for this would be in a Dockerfile if we are to package the materials that way, in the future (which would be sensible, perhaps). 2) I want us to be able to create the users on the VM without also copying materials into their$HOME
as in https://github.com/widdowquinn/Teaching-IBioIC-Intro-to-Bioinformatics/pull/17/commits/83986121e658bdeef80ab9fff5b5afb7daa7c110. If we copy materials across, we significantly bloat the virtual HD, with implications for our filehosting, and the ease of VM transfer. I would rather that we have a separate script to copy the materials/repo across users, than combining both actions.