search

widelands / widelands

Widelands is a free, open source real-time strategy game with singleplayer campaigns and a multiplayer mode. The game was inspired by Settlers II™ (© Bluebyte) but has significantly more variety and depth to it.
https://www.widelands.org/
GNU General Public License v2.0
2.01k stars 156 forks source link

crash while hosting tournament game #4924

Open markusu49 opened 3 years ago

markusu49 commented 3 years ago

Describe the bug The game crashed while waiting for other players to join (2021 tournament round 3).

Logs

[00:01:19.515 real] WARNING: Map/Save is a directory! No way for making it available a.t.m.!
[00:02:55.350 real] WARNING: [Host]: disconnect_player_controller(4, WorldSavior)
[00:02:55.412 real] WARNING: [Host]: disconnect_client(0, SOMETHING_WRONG, 1 Erweiterungsdiskrepanz erkannt:
[00:02:55.412 real] WARNING: · „first_heroes_win.wad“ vom Host benötigt aber nicht gefunden)
[00:03:15.503 real] WARNING: [Host]: disconnect_player_controller(4, WorldSavior)
[00:03:15.612 real] WARNING: [Host]: disconnect_client(0, SOMETHING_WRONG, 1 Erweiterungsdiskrepanz erkannt:
[00:03:15.612 real] WARNING: · „first_heroes_win.wad“ vom Host benötigt aber nicht gefunden)
[00:03:18.036 real] WARNING: [Host]: disconnect_player_controller(4, the-x1)
[00:03:18.141 real] WARNING: [Host]: disconnect_client(0, SOMETHING_WRONG, 1 Erweiterungsdiskrepanz erkannt:
[00:03:18.141 real] WARNING: · „first_heroes_win.wad“ vom Host benötigt aber nicht gefunden)
widelands: /data2/widelands/src/network/nethostproxy.cc:76: virtual std::unique_ptr<RecvPacket> NetHostProxy::try_receive(NetHostInterface::ConnectionId): Zusicherung »clients_.at(id).state_ == Client::State::kConnected« nicht erfüllt.
Aborted (core dumped)

Version:

Noordfrees commented 3 years ago

I cannot reproduce this with 21d093f8db8f4b6285255e0cdc1ba1ffae539dd3, neither in LAN nor lobby. Can someone else please check if this is an urgent issue or already fixed?

frankystone commented 3 years ago

[00:03:18.141 real] WARNING: · „first_heroes_win.wad“ vom Host benötigt aber nicht gefunden)

The add-on is called "Tournament 2021 Win Condition (Tournament_2021_win_condition.wad).

Maybe related?

markusu49 commented 3 years ago

I was still setting up the game, I cannot say for sure if I already had selected the map or the right win condition when it crashed.

EDIT: In a second try my opponent hosted the game successfully, so it's not that urgent.

hessenfarmer commented 3 years ago

Maybe it is urgent. The client was disconnected several times due to a Addon-mismatch. While the host tried to progress it seems there might still have been a reference to the disconnected client as an an assertion failed that was expecting a client to be connected.

Noordfrees commented 3 years ago

I tried connecting to a host using add-ons from a client with no add-ons installed several times. In all cases the expected bounce-back worked smoothly for the host and all clients. So if someone finds a reliable way to reproduce the bug I'll write an urgent fix; otherwise it's probably a once-a-year race condition near-impossible to investigate directly

tothxa commented 1 year ago

Can we close this, as any new occurence now should get a better debug log?