widelands / wl_addons_server

Provides the add-ons server and all add-ons for the Widelands game.
https://www.widelands.org
Other
6 stars 4 forks source link

Problem with stonecutter #123

Closed Nick222 closed 1 year ago

Nick222 commented 2 years ago

The stonecutter tries to get out of the hut, reaches the nearest flag - and comes back. And so on ad infinitum...

frankystone commented 2 years ago

Hi Nick222,

is this related to a widelands add-on? If not this should go into the widelands issue tracker.

Please describe in more detail what is happening, which version do you play, the OS, which add-ons are activated and so on. Also add a save game :-)

Nick222 commented 2 years ago

Xubuntu 21.10 Widelands 1.0 European Tribe 2.2.6+88 replays.zip

frankystone commented 2 years ago

Thanks for the information.

I have informed MarcMcWire, who made this add-on :-)

Noordfrees commented 2 years ago

@MarkMcWire friendly ping :) what is the status here?

MarkMcWire commented 2 years ago

There is some bug I've created. The advanced_stonecutter can become a advanced_stonemason, also the normal_stonemason can become a advanced_stonemason. This caused a crash in my AI-Test-games, because game can't handle this. (Two workers can become another worker (identical) with experience points.)

But I don't think this is related to the problem from above. Nevertheless, I made several updates, mainly because the German translations were wrong because _push_textdomain("europeanstribe.wad", true) was missing and instead _pushtextdomain("tribe", true) was in some entries.

Maybe the other bug is gone, too. Newest Version is 2.3.2, i've uploaded moments ago.

hessenfarmer commented 2 years ago

@Nick222 did you test with latest addon version? can this be closed?

Nick222 commented 2 years ago

@Nick222 did you test with latest addon version? can this be closed?

Addon version 2.4.5+93 - NO

MarkMcWire commented 2 years ago

Sorry for the late reply. 2 weeks ago my computer broke down and it took me so long to get a new one. Unfortunately, some of my old data has also been lost. I'm trying to take care of the problem.

The Stonecutter currently has two operations. Once he cuts rocks from the map to create granite or marble, or he mines ressource_stone from mountains.

If he cannot find either of these things in the work area, the worker will leave the house briefly and then come back in again.

Although I have programmed a finde resource check, it still behaves like this.

Nick222 commented 2 years ago

There is a lot of rocks in stonecutter area - but the worker leave the house briefly and then come back in again.

MarkMcWire commented 2 years ago

There is a lot of rocks in stonecutter area - but the worker leave the house briefly and then come back in again.

I've increased search radius for rock. Did it have any effect on your problem?

Nick222 commented 2 years ago

The problem is that at the end of the construction of the quarry, the worker begins to extract stone, however, after extracting 5 units of stone, he stops doing this and enters the cycle I described above.

I think the search radius has nothing to do with it...

hessenfarmer commented 2 years ago

the problem is the mining program of the worker. after a findspace command a walk=object makes no sense but it should have been a walk=coords see fisher programs for example

Nick222 commented 2 years ago

Now (version addon 2.4.7+95) mining has begun to go on continuously, but for some reason, a quarry worker extracts quartz and diamonds from the first level, and not, as before, from the second or third...

MarkMcWire commented 2 years ago

Now (version addon 2.4.7+95) mining has begun to go on continuously, but for some reason, a quarry worker extracts quartz and diamonds from the first level, and not, as before, from the second or third...

Yes, thats no bug but a feature. Quartz and diamond are necessary for recruiting soldiers and the AI stalls some times, so I expanded the extraction of quartz and diamond to all stonecutters, but with different speeds and frequencies.

Nick222 commented 2 years ago

OK :)

But why normal quarry can only destroy - not to deconstruct ?