widerules / frozenbubbleplus

Automatically exported from code.google.com/p/frozenbubbleplus
0 stars 0 forks source link

Firing with directional pad/keyboard keys can fire continuously with a sustained press #37

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In previous versions, firing the bubble required a new keypress for each launch 
of the bubble.

In version 1.15, as soon as the launched bubble "sticks", if the key is still 
pressed, the next bubble in the launcher will launch.

A change was made per issue #27 to eliminate the need to fire twice to launch 
the bubble when aim-then-shoot mode was selected - this fix may have been a 
little heavy handed, as instead of just fixing the issue (which it did), it 
also introduced the above behavior, where a sustained press can produce 
multiple launches.

Some investigation is still needed to determine if the current behavior is more 
or less desirable than the previous behavior based on player feedback.  It 
should be noted that the touch-based firing does not do the same - a new touch 
is required for each bubble launch.

Original issue reported on code.google.com by forter...@gmail.com on 22 May 2013 at 12:40

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
I have found that the issue lies with a bug in the processing of doKeyUp() - 
the key release processing should always be allowed in any game state, not just 
if the game is running.

This has been fixed.

This fix will be released in version 1.16, and will also revert the bubble 
launching behavior back to a single launch per key press per the original 
implementation.

Original comment by forter...@gmail.com on 23 May 2013 at 3:59

GoogleCodeExporter commented 9 years ago
Released in version 1.16.

Original comment by forter...@gmail.com on 19 Jun 2013 at 10:50