Closed clarsen closed 3 years ago
Hi,
Many thanks for providing this pull request. I'm not sure when we'll get a chance to look at it proper, as things are pretty full-on at this stage. That said, it's likely we'll be merging to develop
rather than master
. (master
is for releases… as per Git Flow.)
Some things that will be needed:
dict
s (not sure if that's in there already or not, it's been a long time!)Hi @clarsen, many thanks for your contribution. I've had a look and ran into a few road blocks as I found the code broke some existing tests.
I'm taking a look at #32 which looks like it may also be tackling the same issue… among others. I may come back to this PR, we'll see if there's anything missing.
Hi @clarsen, I've merged the other pull requests and released version 1.3.1, could you try that out and see if that meets your use case for reading dicts?
Many thanks. Regards, Stuart Longland
I haven't heard any feedback for the past few months, in the interests of keeping things moving, I'll now close this pull request.
If there's something from here though that needs re-visiting, please let us know and we can re-open it and have another look.
Although this doesn't handle general cases, it is working for us.
Partial addressing of https://github.com/widesky/hszinc/issues/8
issues:
TODO: