search

widget- / slack-black-theme

A darker, more contrasty, Slack theme.
Apache License 2.0
1.75k stars 407 forks source link

Fix theme for Slack 3.2.0 #60

Open Nockiro opened 6 years ago

Nockiro commented 6 years ago

Since the codes and workarounds in #48 do work but don't include the theme colors anymore, this should fix most of the broken areas taking the theme variables into account.

eduardonunesp commented 6 years ago

Looks like the threads input text aren't following the theme. https://cl.ly/37210F1b0E3U

eduardonunesp commented 6 years ago

User local time isn't appearing correctly image

intere commented 6 years ago

@widget- any chance you can get this tested / merged in? For now I've just updated the reference JS to point to @Nockiro's fixes. It's looking good on my systems.

intere commented 6 years ago

@widget- any chance you could take a look at this?

parga commented 6 years ago

@widget- can we have this merged ?

neemzy commented 5 years ago

@widget- Hello! Is there any chance you might take a look at this? Thanks a lot! :)

SystemDisc commented 5 years ago

@Nockiro There are still a couple places in All Threads and the Thread Sidebar on the right where the theme is broken, even in the latest commit in this PR.

Thanks so much for fixing pretty much everything, though.

ssoroka commented 5 years ago

Until this is merged, I forked the repo and merged Nockiro's two fix branches. ~you can use this patched version at https://raw.githubusercontent.com/ssoroka/slack-black-theme/master/custom.css~

Edit: Or use Nockiro's master branch in the next post; he seems more likely to keep it up to date anyway. :)

Nockiro commented 5 years ago

@SystemDisc I can't find any, if you could take a screenshot of the glitches, it would maybe help me to see them - thanks for reporting, though! @ssoroka Actually the current master branch (https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css) should have everything you need, I just keep the two fix- branches separately to (if the time should ever come) merge the changes into this repository over a new pull request - I just didn't want to open a second pull request for the >3.3 changes as long as the first one isn't even merged yet.

treycedits commented 5 years ago

@Nockiro thanks for all the fixes! Unfortunately I tried using the master branch but when opening Slack it just infinitely shows the loading screen and 'Connecting to Slack'. Anything I'm doing wrong?

SystemDisc commented 5 years ago

@Nockiro I'm using the most recent commit in this PR. Here's what I see:

screen shot 2019-02-05 at 11 35 37 am screen shot 2019-02-05 at 11 35 01 am
elv1n commented 5 years ago

I'm supporting https://github.com/elv1n/slack-dark-mojave-theme to be up to date with slack updates

metaskills commented 5 years ago

Changed my CSS line to const cssPath = 'https://raw.githubusercontent.com/widget-/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css'; and this worked well.

SystemDisc commented 5 years ago

I've switched to using https://github.com/elv1n/slack-dark-mojave-theme. As of today, there's an issue with the "All Threads" view, but it seems a lot easier to use and seems to get updates more frequently - at least for now.