widget- / slack-black-theme

A darker, more contrasty, Slack theme.
Apache License 2.0
1.75k stars 410 forks source link

Chat box background is still staying in white v3.2.0 #62

Closed khanhletv closed 6 years ago

khanhletv commented 6 years ago

Hi there,

I have applied some sample color schema but the chat box background still stay in white.

Thanks and regards,

jhollowed commented 6 years ago

Currently experiencing the same issue :( Slack version 3.2.1 on Ubuntu 16.04

MalPr0c3ss commented 6 years ago

Same here...

Win 10 Pro x64 ver. 10.0.17134

Blizzardo1 commented 6 years ago

I'm also experiencing this.

intere commented 6 years ago

@Nockiro has fixed this in this PR: https://github.com/widget-/slack-black-theme/pull/60

khanhletv commented 6 years ago

Thank you, I will try and let you know once it was fixed.

intere commented 6 years ago

@khanhletv - it is fixed, you have to (temporarily) reference https://raw.githubusercontent.com/Nockiro/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css instead of the css that's currently in master. Once that PR gets merged into master, it will be fixed.

khanhletv commented 6 years ago

@intere yep, it works perfectly. Thanks for helping me out and this issue should be closed for now.

jhollowed commented 6 years ago

referencing the alternative css url given above by @intere had no change for me on Ubuntu 16.04

zerodivisionerr commented 5 years ago

@khanhletv - it is fixed, you have to (temporarily) reference https://raw.githubusercontent.com/Nockiro/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css instead of the css that's currently in master. Once that PR gets merged into master, it will be fixed.

Thank you so much! Verified working on MacOS Mojave, Slack version 3.3.3!

mingrammer commented 5 years ago

It works for me too

josephtoles commented 5 years ago

This fix works on Linux running Slack version 3.3.3.

monkpit commented 5 years ago

This fix makes all colors from the Jenkins bot turn to black. They used to be various colors based upon the status of the Jenkins job (Green for success, red for failed, etc)... screen shot 2019-01-02 at 11 03 15 am

Nockiro commented 5 years ago

Hi @monkpit, I didn't continue with the pull request here as slack 3.3 needed other fixes and I didn't want to open a new pull request with the old one not merged yet. Despite that, I continued to adjust the theme on my fork - including the mentioned colors, if you try https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css, the colors should work correctly.

harveymonster commented 5 years ago

Hi @Nockiro, I linked to the CSS on your fork and noticed that if you edit a message from within a thread, the textbox doesn't have the dark background.

image

Nockiro commented 5 years ago

Hi @harveymonster, thanks for the hint! Fixed it and gave it the same background the standard edit inputs have, the elevated background.

mark-bixler commented 5 years ago

Confirmed this works on Mojave, Slack 3.3.6.

If you're having issues on Mojave, verify the way you're editing your index.js & ssb-interop.js files.

I originally was using vscode to edit, copy and paste and didn't realize formatting was all jacked up.

I ended up using textmate to copy and paste css and it works great now!

kyub commented 5 years ago

There is still a white box appearing at the top in All Unreads and All Threads.

slack_theme

CliffWheadon commented 5 years ago

@kyub That appears to be gone if you switch to using the most recent css from Nockiro's fork: https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css

bjorkmeister commented 5 years ago

@khanhletv - it is fixed, you have to (temporarily) reference https://raw.githubusercontent.com/Nockiro/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css instead of the css that's currently in master. Once that PR gets merged into master, it will be fixed.

This works on MacOS Mojave 10.14.2. Thanks.

harveymonster commented 5 years ago

Hey @Nockiro, I'm assuming slack has made a layout change around threads recently because the reply box in a thread is no longer dark. image

Also, I noticed that if you are a part of a slack team where the admin has limited who can post to the "general" channel the message that replaces the textbox to type a message is still light. image

Nockiro commented 5 years ago

Hi @harveymonster, thanks for noticing! Fixed both (and with it a few other things in the process).

dchaid commented 5 years ago

Feeling dumb. I'm using https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css but my theme is still very, very white.

ssb-interop-dchaid.txt

Nockiro commented 5 years ago

In the file you attached it seems like you added the code somehow nested and twice? That impacts the result, you have to use the code specified in the Readme from line 100 in your case.

edswangren commented 5 years ago

Not working at all for me, Win10 slack 3.3.6

The master version has the white message area and it seems like neither of the new css links in this thread are being loaded.

index.txt ssb-interop.txt

jhollowed commented 5 years ago

I've tried many times over the past few months, and none of the solutions here work for me either on Ubuntu 16.04, Slack 3.3.3. Why can't this finally be fixed in master? It literally makes the dark theme not dark

iniquityx2 commented 5 years ago

Confirmed this works on Slack 3.3.7 64 windows 10

edswangren commented 5 years ago

Working for me after moving to 3.3.7 as well. No idea.

mB-PiBox commented 5 years ago

Not able to get this to work on Slack 3.3.8

iniquityx2 commented 5 years ago

Worked for me just fine on 3.3.8 - Windows 10 x64

bison92 commented 5 years ago

@iniquityx2 please tell us what you had to do ??

iniquityx2 commented 5 years ago

nothing other than going into the new folder location \slack\app-3.3.8\resources\app.asar.unpacked\src\static\index.js and and ssb-interop.js and inserting the section from the main help on this repo.

I did of course have to put in the modified css https://raw.githubusercontent.com/Nockiro/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css

This has worked on two different windows 10 x64 machines without issue

Snowflake6 commented 5 years ago

Odd. This worked fine for me on 3.3.7, but on 3.3.8 i'm back to getting a white message area with black text. Both with the stock section from the readme.md and with the modified css that @iniquityx2 mentions. Same result.

Snowflake6 commented 5 years ago

Gah. And now, after four re-starts, it starts working. No change to the code. I guess there's some cache-ing going on somewhere?

iniquityx2 commented 5 years ago

Glad it started working for you all. Was starting to wonder if I should post my configs.

I didn't experience the delay on getting it to work though there was about 5 seconds where it was the normal theme and then it switched over

Snowflake6 commented 5 years ago

And now Windows is offering an update, so maybe it was running slow for some reason as well while the update was downloading. In any case, seems to be working after a short delay.

iniquityx2 commented 5 years ago

Still working on Slack 3.40