widget- / slack-black-theme

A darker, more contrasty, Slack theme.
Apache License 2.0
1.75k stars 407 forks source link

its not working on windows 10, css is buggy #86

Open alikrc opened 5 years ago

Sharpienero commented 5 years ago

Confirmed. V 3.3.8

McGiogen commented 5 years ago

The same on linux (kde on opensuse tumbleweed). Slack version 3.3.7

LesterCovax commented 5 years ago

As was mentioned in another issue, just use https://raw.githubusercontent.com/Nockiro/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css for the CSS URL instead of what's in the instructions.

Nockiro commented 5 years ago

Because I see this in other discussions, too: The mentioned URL has become pretty much outdated by now as it is from almost 9 months ago. I'd recommend using the generic https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css URL or - for those who don't trust this one - at least the most recent static one https://raw.githubusercontent.com/Nockiro/slack-black-theme/a507b08574d35480a7adaf8da39c44fb3a54e4ee/custom.css here.

mark3done commented 5 years ago

I tried all the following:

https://raw.githubusercontent.com/Nockiro/slack-black-theme/3ea2efdfb96ccc91549837ab237d57104181bbf8/custom.css

https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css

https://raw.githubusercontent.com/Nockiro/slack-black-theme/a507b08574d35480a7adaf8da39c44fb3a54e4ee/custom.css

But all render the same results with the thread showing white still. Everything else, such as chats, sidebar etc.. is fine. Threads are white background with greyish text. Anything additional needs to be done for 3.3.8?

diegogac commented 5 years ago

Same here, Everything looks good except for "All Threads" -- complete white background with grey letters and the reply box is actually dark

Nockiro commented 5 years ago

Thanks for the report, should be working now with https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css or https://raw.githubusercontent.com/Nockiro/slack-black-theme/ec9123b9064b1c001331ac0f38100fdbe5b08686/custom.css

diegogac commented 5 years ago

Yup, it works now! Great stuff Nockiro!

mark3done commented 5 years ago

Confirmed. Good stuff. Thanks!

On Thu, Mar 21, 2019 at 3:07 PM diegogac notifications@github.com wrote:

Yup, it works now! Great stuff Nockiro!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/widget-/slack-black-theme/issues/86#issuecomment-475364075, or mute the thread https://github.com/notifications/unsubscribe-auth/AuiwYI0DTPRUFsDXsiustby1tUhj1Tu1ks5vY9hrgaJpZM4bq_Z5 .

iAbadia commented 5 years ago

Thanks for the report, should be working now with https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css or https://raw.githubusercontent.com/Nockiro/slack-black-theme/ec9123b9064b1c001331ac0f38100fdbe5b08686/custom.css

Having some issues with notifications, there's a dark square behind it. Am I the only one?

image

JHarding86 commented 5 years ago

This did not fix it for me, still showing white...

JOY commented 5 years ago

I can switch to black theme but then I cannot switch back to normal theme any more by replace the stock file of Slack. Could you please help @Nockiro ?

Nockiro commented 5 years ago

@JHarding86 Try using the most current file (https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css) - if that does not work, could you specify where you see the white space exactly? @LeGiangAnh You have to close slack before reverting your changes in the files (don't forget to remove them from index.js and the ssb-interop.js), that should usually work.

shay-thompson commented 5 years ago

Confirmed Works with 3.3.8 on Win7

TeddJohnson commented 5 years ago

Thanks for the report, should be working now with https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css or https://raw.githubusercontent.com/Nockiro/slack-black-theme/ec9123b9064b1c001331ac0f38100fdbe5b08686/custom.css

Having some issues with notifications, there's a dark square behind it. Am I the only one?

image

no, I have this same issue. I haven't found a solution yet.

iAbadia commented 5 years ago

Thanks for the report, should be working now with https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css or https://raw.githubusercontent.com/Nockiro/slack-black-theme/ec9123b9064b1c001331ac0f38100fdbe5b08686/custom.css

Having some issues with notifications, there's a dark square behind it. Am I the only one? image

no, I have this same issue. I haven't found a solution yet.

I've changed to windows notifications instead of Slack's to avoid it.