search

widgetbook / widgetbook

Widgetbook is the custom widget library and collaboration platform for Flutter frontend teams.
https://widgetbook.io
740 stars 182 forks source link

Android hardware button quit widgetbook application #1177

Open mjablecnik opened 4 months ago

mjablecnik commented 4 months ago

Description When I run Widgetbook in mobile device, I have a bottom panel with 3 icons (Navigation, Addons, Knobs). When I click on one icon so modal popup is showed with content. For close this modal you can swipe it down or click outside. But when you accidentally click on Hardware button in Android, whole application is closed.

Steps To Reproduce

  1. Start Widgetbook in Android mobile
  2. Click on Addons icon in bottom panel
  3. Click on hardware android button
  4. Whole application is closed

Expected Behavior When is opened modal popup, close this popup. When is not opened modal popup, show dialog with question if I really want to quit whole application.

yousinix commented 4 months ago

Hello @mjablecnik 👋

As this issue might be a low-priority to us compared to other issues that affect web/desktop, do you want to work on fix for this?

IvanGael commented 3 months ago

Hello ! I want to contribute to Widgetbook. Can I work on this issue ?

mjablecnik commented 3 months ago

@YoussefRaafatNasry Now I do not have a time so @IvanGael if you want to work on this issue you can do it ;)

yousinix commented 3 months ago

Hello @IvanGael 👋

Great to hear that you want to contribute on Widgetbook! 💙 I am assigning this issue to you, and let me know if you need any help.

Our mobile layout is managed in this file, so it can be a good starting point.

IvanGael commented 3 months ago

Okay good @YoussefRaafatNasry . I'll start to work on it soon. I will get back to you if I have any questions.

IvanGael commented 2 months ago

Hello @YoussefRaafatNasry @mjablecnik ! I just submit a PR for this issue. Let me know your thoughts.

Here is a link : https://github.com/widgetbook/widgetbook/pull/1200