Properly compare PHP's shorthand byte values

widgetfactory / jce-legacy

JCE - A Content Editor for Joomla!

4 stars 2 forks source link

Properly compare PHP's shorthand byte values #5

Closed stevenrombauts closed 8 years ago

stevenrombauts commented 9 years ago

The current logic assumes that memory_limit is always described in Megabytes. However, if the memory_limit is expressed in Gigabytes for example, the script will think it's less than 32 Megabytes and lower the memory limit.

This happened to me while testing joomlatools/joomla-composer#16. PHP's memory_limit was set to 1G but JCE installation lowered it to 32M :)

ryandemmer commented 8 years ago

Attempt to set memory_limit has been removed - https://github.com/widgetfactory/jce/commit/771700134d9504ef02f6e8ca430d7947d834ed24