widgetfactory / jce

JCE - A Content Editor for Joomla
https://www.joomlacontenteditor.net
GNU General Public License v2.0
35 stars 12 forks source link

Under some circumstances modal-footer of Joomla media modal hidden by JCE's media.css #104

Closed ReLater closed 2 years ago

ReLater commented 2 years ago

I know how to fix it in my extension but wanted to report it here. Maybe a bug. Maybe not. Don't waste your time with it ;-)

Describe the bug

One has a field (type media):

<field name="foto" type="media" default=""
label="MOD_SPLIDEGHSVS_FOTO"
preview="true"/>

The other a field (type mediajce):

<field name="lederBG" type="mediajce" default=""
addfieldpath="plugins/system/jce/fields"
label="Bla bla"/>

Screenshots grafik

grafik

ryandemmer commented 2 years ago

Fixed in commit - https://github.com/widgetfactory/jce/commit/c10cb829ad02ea8705d30798a870602b6fab75e8

Thank you.

ReLater commented 2 years ago

Works so far and the buttons are visible.

But: For the form field with type="mediajce" the height of the <div modal-body> is too low now.

See images please. Joomla 4.0.5 backend. Firefox.

1

grafik

grafik

2 (changed via browser inspector)

grafik

grafik

ryandemmer commented 2 years ago

Fixed in https://github.com/widgetfactory/jce/commit/451403d8201f550d66d8ce4f63467f688dab8ae3 and https://github.com/widgetfactory/jce/commit/c396cc8bfae2d58e7f390f4f9475fb58d6fc0897

ReLater commented 2 years ago

Everything looks fine now in my test case above. Thanks!