widgetti / ipyreact

React for ipywidgets that just works. No webpack, no npm, no hassle
BSD 3-Clause "New" or "Revised" License
104 stars 8 forks source link

Add Ipyreact walkthrough tutorial #11

Closed kolibril13 closed 1 year ago

kolibril13 commented 1 year ago

This Ipyreact walkthrough tutorial is based on conversations from https://github.com/widgetti/ipyreact/issues/5 https://github.com/widgetti/ipyreact/pull/7#issuecomment-1520624313 and https://github.com/widgetti/ipyreact/pull/3

and here is a binder version of it: https://mybinder.org/v2/gh/kolibril13/ipyreact/binder?labpath=examples%2Ffull_tutorial.ipynb (note that binder is a bit slow today.)

kolibril13 commented 1 year ago

@paddymul : would you be interested in giving me some feedback on this? :) From the commit 22c16e3 I created an interactive jupyterlite web version that can be found here: https://octoframes.github.io/ipyreact-jupyterlite/lab/index.html Let me know if any chapter is missing or if something needs more/less detail.

paddymul commented 1 year ago

starting to look at it. I'm at a conference - PyData Seattle, and travelling over the next few days, so I'm not sure how much time I have. I will try to give some good comments.

On Fri, Apr 28, 2023 at 6:22 AM Jan-Hendrik Müller @.***> wrote:

@paddymul https://github.com/paddymul : would you be interested in giving me some feedback on this? :) From the commit 22c16e3 https://github.com/widgetti/ipyreact/commit/22c16e36496a535b7f74aa42eab889579a036d49 I created an interactive jupyterlite web version that can be found here: https://octoframes.github.io/ipyreact-jupyterlite/lab/index.html Let me know if any chapter is missing or if something needs more/less detail.

— Reply to this email directly, view it on GitHub https://github.com/widgetti/ipyreact/pull/11#issuecomment-1527557642, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJ4BMISX5TQSQ4MM5UUDLXDPADBANCNFSM6AAAAAAXMG6N54 . You are receiving this because you were mentioned.Message ID: @.***>

maartenbreddels commented 1 year ago

Just want to let you know it’s heart warming to see these commits come in 😀 Hope I can review this soon!

kolibril13 commented 1 year ago

Thanks a lot for your review! Really looking forward to reading and incorporating your comments later today.

kolibril13 commented 1 year ago

Thanks again for your comments, I think I was able to incorporate most of them. As this PR is quite large, what do you think about merging this already? Further possible tweaks could then be discussed in issues and resulting changes can be made in smaller follow-up-prs.

paddymul commented 1 year ago

I have lost track of all of the changes in the PR too. I think we should merge this and take another pass

kolibril13 commented 1 year ago

I have lost track of all of the changes in the PR too. I think we should merge this and take another pass

I also found it hard to keep the overview! I have the feeling that a GitHub PR is currently not the right format to make this kind of documentation changes in notebooks. From my experience, having a synchronous pair-programming sessions and discussing things section by section is a better approach to handle this kind of content.

paddymul commented 1 year ago

I agree. Reach out sometime, we should catch up

kolibril13 commented 1 year ago

Great idea! For synchronous chatting, feel free to write me on discord if you're on that platform, there I'm kolibril13#7832 I have the projects jupyter-mafs and jupyter-tldraw based on ipyreact that can soon be shipped, and it would be amazing to hear your opinions on that!

image

Next week I'm at JupyterCon, but afterwards I'm up for an exchange!

maartenbreddels commented 1 year ago

Thanks a lot! 🥳