widgetti / ipyvolume

3d plotting for Python in the Jupyter notebook based on IPython widgets using WebGL
MIT License
1.95k stars 236 forks source link

UI Tests check is failing on CI #413

Closed jtpio closed 1 year ago

jtpio commented 2 years ago

Opening a new issue since the check is failing on the latest commit on master: https://github.com/widgetti/ipyvolume/commit/1c08f9fdde4219be873f7c45e02ecec2540d5876

image

Opening the report shows some differences with the UI elements:

image

Not sure if this was introduced in a previous PR, but probably updating the reference snapshots should help fix it.

jtpio commented 2 years ago

Also the UI Tests setup could be updated to use a more recent @jupyterlab/galata based on Playwright: https://github.com/jupyterlab/jupyterlab/tree/master/galata

For example:

jtpio commented 2 years ago

Upgrading to the newer setup would also allow for integrations like automated snapshots updates with a bot: https://github.com/jupyterlab/maintainer-tools#update-snapshots

maartenbreddels commented 1 year ago

Partially fixed in https://github.com/widgetti/ipyvolume/pull/424 (not yet upgraded, will keep that in mind!)