Closed jtpio closed 1 year ago
Also the UI Tests setup could be updated to use a more recent @jupyterlab/galata
based on Playwright: https://github.com/jupyterlab/jupyterlab/tree/master/galata
For example:
Upgrading to the newer setup would also allow for integrations like automated snapshots updates with a bot: https://github.com/jupyterlab/maintainer-tools#update-snapshots
Partially fixed in https://github.com/widgetti/ipyvolume/pull/424 (not yet upgraded, will keep that in mind!)
Opening a new issue since the check is failing on the latest commit on
master
: https://github.com/widgetti/ipyvolume/commit/1c08f9fdde4219be873f7c45e02ecec2540d5876Opening the report shows some differences with the UI elements:
Not sure if this was introduced in a previous PR, but probably updating the reference snapshots should help fix it.