fix: _remove_element failing silently when child objects left over

widgetti / reacton

A pure Python port of React for ipywidgets

https://reacton.solara.dev/

MIT License

289 stars 19 forks source link

fix: _remove_element failing silently when child objects left over #34

Closed iisakkirotko closed 4 months ago

iisakkirotko commented 4 months ago

This used to happen with Solara, I think because https://github.com/widgetti/solara/blob/c8ca20f8b137058e7e2374ed2a024320808875be/solara/server/patch.py#L521-L539 would react to a widget being (unexpectedly) deleted before the exception from reacton would be rendered.

The reason why we could have a situation where no exception was displayed would also be fixed by this change - previously any AssertionErrors were not being added to any context exception list

iisakkirotko commented 4 months ago

#35
#34 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite

iisakkirotko commented 4 months ago

Merge activity

Apr 26, 5:51 AM EDT: @iisakkirotko started a stack merge that includes this pull request via Graphite.
Apr 26, 5:51 AM EDT: @iisakkirotko merged this pull request with Graphite.