widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.62k stars 105 forks source link

ipywidgets slider not working with Solara >v1.17.0 #169

Closed giswqs closed 4 months ago

giswqs commented 11 months ago

The ipywidget slider used to work fine with Solara v1.17.0 and earlier. image

However, the slider no longer show up with Solara v1.17.1. Is there any changes recently that affect ipywdiget slider? image

maartenbreddels commented 11 months ago

Thank you for reporting!

I can confirm this happened in 1.17.1

maartenbreddels commented 11 months ago

Fixed in f1fac8a666879139cead66ca44296a75a00c381c and released as 1.17.3 🥳

giswqs commented 11 months ago

Thank you for the quick fix. One minor issue is that the right end of the slider is a but cut off. See below. It worked perfectly in Solara v0.17.0. as well as in Jupyter notebook (without Solara). Not sure if it is a style issue.

In Jupyter Notebook image

In Solara web app image

maartenbreddels commented 11 months ago

Again, thanks for letting me know!

kirimaru-jp commented 9 months ago

@maartenbreddels I have the same problem like @giswqs , hence I would like to find out why it happened in order to fix it. However, I did not know how to track the changes you made, e.g. this one seems to be incorrect.

Could you please tell me how to find the changes?

maartenbreddels commented 4 months ago

https://github.com/widgetti/solara/pull/450 might solve this. We'll release this soon (1.25.2 or 1.26.0)