widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.62k stars 105 forks source link

feat: add disable keyword to select and select multiple widgets #173

Closed lp9052 closed 11 months ago

lp9052 commented 11 months ago

add disabled keyword to select widgets see #144

lp9052 commented 11 months ago

first PR. Want to use this to familiarize with the process.

Let me know if there are specific rules for this project.

I followed instruction from development page.

Once this merged, I'll be able to contribute more.

Happy Friday.

lp9052 commented 11 months ago

Thanks Maarten!

I'll remove the test in component test.

And is there any specific reason we prefer Test() over under_test() or test()? As snakecase is the preferred convention. Pep8 will report otherwise.

lp9052 commented 11 months ago

urrr. I don't see components_test.py. Can you point out to me where is it?

maartenbreddels commented 11 months ago

I see it is never added to git 🙃 But we use the CamelCase because components are special functions, they are lazy, get re-executed, and contain state, which makes them behave more like classes.

lp9052 commented 11 months ago

just merged changes and please take a look

maartenbreddels commented 11 months ago

Thank you!