Feat: add switch widget

[lp9052]

add switch widget

see #174

[lp9052]

Do we have permission to rerun failed test?

[maartenbreddels]

Thank you 🙏

Apparently, you need to have write access for the repo to do that. I'm happy to restart it though

[lp9052]

Thanks Maarten.

I guess checkbox is one of the earlier piece that doesn't have all the new styles. All the enhancements make sense to me. I shall update checkbox too. I'll start a new PR for checkbox.

[lp9052]

take a look.

one small concern, we are passing [] as default parameter, it's mutable.

should we do the following:

    children: Optional[list] = None,
    classes: Optional[List[str]] = None,

[maartenbreddels]

I guess checkbox is one of the earlier piece that doesn't have all the new styles. All the enhancements make sense to me. I shall update checkbox too. I'll start a new PR for checkbox.

indeed, and that would be great!

one small concern, we are passing [] as default parameter, it's mutable.

Yes, that's also something I usually frown upon... we are using that in many places because it also keeps the typing simpler so lets stick to it for now and if we change it, we'll do it throughout the whole codebase.

[lp9052]

hmmm, the testing suit seems somewhat unstable.

also I want to open up an issue about unit test doesn't all pass out of the box.

it requires some other packages as solar enterprise, etc.

[maartenbreddels]

Hmm, it's been a while since that test failed. Before we saw that one fail more often, see https://github.com/widgetti/solara/issues/131 for some comments/clues. The integration test also has 1 flakey test.

[lp9052]

lmk if you have more comments else we can merge this.

I have one more PR coming up.

Thanks

[lp9052]

Hmm, it's been a while since that test failed. Before we saw that one fail more often, see #131 for some comments/clues. The integration test also has 1 flakey test.

it's a quite interesting issue. I always like to see coverage info. And in my opinion 100% coverage is a must if we want to push this project further and accept more contributors

[maartenbreddels]

I agree. A possible option might be to explicitly set intrusive_cancel in https://solara.dev/api/use_thread and only test that intrusive_cancel feature separately. Still, I find it really suspicious/odd that even after 10 seconds it does not finish the thread execution. I've stared at this failure many times and thought about it many times, but it might need a fresh pair of eyes.

[maartenbreddels]

There are 2 few missing I think TODO:

• [ ] Add to solara/website/pages/api/init.py
• [ ] Add a gif to solara/website/public/api/

I'm happy to pick this up if this is too much to ask. But this would also make this PR a nice template for new components.

[lp9052]

There are 2 few missing I think

TODO:

• [x] Add to solara/website/pages/api/init.py

• [x] Add a gif to solara/website/public/api/

I'm happy to pick this up if this is too much to ask. But this would also make this PR a nice template for new components.

Give me a day or two. I might run into problem for gif. But I'll let you know. Thanks.

[lp9052]

Added these two pieces per suggestion.

[lp9052]

@maartenbreddels

[maartenbreddels]

Thank you! 🙏