ci: run pre commit in ci for code quality

widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps

https://solara.dev

MIT License

1.62k stars 105 forks source link

ci: run pre commit in ci for code quality #225

Open maartenbreddels opened 9 months ago

maartenbreddels commented 9 months ago

Instead of manually keeping pre-commit versions in sync with CI, lets also use pre-commit in CI

maartenbreddels commented 9 months ago

Giving up for now, I have no idea why isort under Python 3.9 decides to reorder imports.

maartenbreddels commented 9 months ago

After d15ec01a36b8a08a2eacead857a3ba36bace1352 it seems that we cannot install isort on Python 3.7 anymore. Might be a clue that the isort on 3.9 in pre commit does not respect the version number in the pre commit file.