widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.9k stars 141 forks source link

Multiple file support for FileDrop #260

Open hkayabilisim opened 1 year ago

hkayabilisim commented 1 year ago

Currently, FileDrop only supports single file upload. If you drag multiple files, it only processes one of them. Is there a plan to implement multiple file support? If you can provide some tips, I can also try to implement it.

maartenbreddels commented 1 year ago

Hi,

this is not on our list yet, but would be nice to have, do you agree @mariobuikhuizen ? I think @mariobuikhuizen also once added support for directories right? There is also https://github.com/widgetti/solara/pull/46 Both are built on top of https://github.com/widgetti/ipyvuetify/tree/master/ipyvuetify/extra which should support multiple files. a PR would we great!

Regards,

Maarten

hkayabilisim commented 1 year ago

I checked the file_drop.py and file_drop.vue. And I got the impression that multiple file support is almost there. I tried to modify them but couldn't make it properly. I'm in a hurry, so, I'm moving on to using multiple FileDrops. If I find time, I will get back and give it a second try.

hkayabilisim commented 8 months ago

I've implemented this feature: https://github.com/widgetti/solara/pull/562