Open Jhsmit opened 1 year ago
This is a nice one, a drop zone which you can also click to browse
(from chatpdf.com)
Thats looks like to more or less already exist / be easy to do https://codepen.io/hkchen/pen/EraZXm
Any updates about this PR? This one provides a more comprehensive file input option than Filedrop, especially the accept and disable keyword. I see you did not explicitly add disable keyword in the param list. Do you want to add it? I do believe it will supported by kwarg, since disable is a common and useful keyword, maybe you want to directly add to the signature?
I've taken a quick look/pass on this PR, and there are some issues
Hope to do another pass soon, but if someone want to pick up some items, that would be great!
I've taken a quick look/pass on this PR, and there are some issues
- ipyvuetify does not pass class, style and label to the vuetify component in the template: https://github.com/widgetti/ipyvuetify/blob/master/ipyvuetify/extra/file_input.vue
- on_file triggers directly with None
- better typing for multiple=True/False
- integration test needed.
Hope to do another pass soon, but if someone want to pick up some items, that would be great!
@maartenbreddels Do you have other tickets/feature you need help? If not, I can take a look at this.
Those would be good to work on, otherwise see https://github.com/widgetti/solara/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22 Would love to see more contributions from you 😍
I agree this would be the best. Maybe we can merge the vue.js script parts of both but this is likely beyond me.
This is probably an ipyvuetify discussion but: For my uses cases I would like to pass additional options, such as
dense=True
, which are currently not implemented in the extra FileInput template. I can make a PR on ipyvuetify, but how do I add these kinds of boolean flags?