search

widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.62k stars 105 forks source link

chore: update javascript package dependencies #484

Closed iisakkirotko closed 2 months ago

iisakkirotko commented 3 months ago

First commit is just bumping nodejs 14 -> 20 to check if build gets the same error as my local machine :)

iisakkirotko commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite Graphite

maartenbreddels commented 2 months ago

There is still an vuetify version bump, you can remove that and update the lockfile please?

iisakkirotko commented 2 months ago

There is still an vuetify version bump, you can remove that and update the lockfile please?

Apparently there is, yeah... The new version matches https://github.com/widgetti/ipyvuetify/blob/7729f015ad384ab1549b25dc21175d3b7f246452/js/package.json#L64, though. Should I change it to what it was instead of that?

maartenbreddels commented 2 months ago

That's the vue3/vuetify3 branch: https://github.com/widgetti/ipyvuetify/blob/vuetify3/js/package.json#L64

for vuetify 2 we use mario's branch

iisakkirotko commented 2 months ago

@maartenbreddels So then all Vuetify versions match, correct? (I also did run npm install, but this produced no change in package-lock.json)

Also, if we want to keep our Vuetify versions in sync with ipyvuetify, perhaps we should hard fix them in both, instead of using the compatible with ~ operator? You can see here that currently npm picks the newest compatible version (i.e. 2.2.34) anyway.