search

widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.62k stars 105 forks source link

fix: json_default supports date serialization #525

Closed maxhollmann closed 3 weeks ago

maxhollmann commented 2 months ago

datetime was already supported, I just added date to json_default as well.

This should fix https://github.com/widgetti/solara/issues/475

maartenbreddels commented 2 months ago

Hi Max,

thanks for the issue, as mentioned in https://github.com/widgetti/solara/issues/475#issuecomment-1968431841 I'm not seeing this in the jupyer_client code: https://github.com/jupyter/jupyter_client/blob/main/jupyter_client/jsonutil.py Lets continue the discussion in that issue. In any case, thank you for opening this high quality PR with a test!

Regards,

Maarten

maartenbreddels commented 3 weeks ago

I'm assuming this is not needed anymore, if you disagree, let us know. In any case, thank you for wanting to contibute.