search

widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.62k stars 105 forks source link

`solara.DataFrame` doesn't display row index names #526

Open kdheepak opened 2 months ago

kdheepak commented 2 months ago

Here's the default display of a dataframe in a Jupyter notebook:

image

Here's how solara displays it:

image

In the second display of the transposed dataframe the row names should be a, b, c, d instead of 0, 1, 2, 3.

maartenbreddels commented 2 months ago

Hi Dheepak,

thanks for opening this issue. This, indeed, seems incorrect. Note that you can also use display(df) in Solara, which uses the same way of displaying the table, but it's not interactive. Do you feel like fixing this? A PR would be welcome!

Regards,

Maarten

kdheepak commented 2 months ago

Hi @maartenbreddels thanks for confirming. I'm happy to make a PR. I'll look into this week!

SarthakNikhal commented 1 month ago

@maartenbreddels Can I work on this issue? @kdheepak Let me know if there's anything I could do

kdheepak commented 1 month ago

If you'd like to take this issue that'd be great! I didn't get a chance to dig into it too much unfortunately.

maartenbreddels commented 4 weeks ago

Hi @SarthakNikhal ,

sounds good. Please also look at https://github.com/widgetti/solara/pull/600 because that might interfere with your plans. I hope we can get that PR in soon, so we won't have much merge conflicts.

cheers,

Maarten

SarthakNikhal commented 3 weeks ago

@maartenbreddels Created a pull request. Please take a look and let me know if there's further work to be done.

SarthakNikhal commented 3 weeks ago

@maartenbreddels updated the function to handle type of iterable. You can review the changes now

SarthakNikhal commented 3 weeks ago

@maartenbreddels Let me know if any further work is required for this