search

widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.6k stars 104 forks source link

Adding documentation to details component #586

Closed mikegiann01 closed 2 weeks ago

mikegiann01 commented 4 weeks ago

This is about issue #222

mikegiann01 commented 4 weeks ago

Thanks for the response! I will follow your istructions and i will let you know on the process. About the documentation on the website i am very interested on working on this, i will check it out and i will let you know.

mikegiann01 commented 3 weeks ago

Hello!! I have some upadates, I followed your instructions and i reached an impasse(shown in the picture):

error

Could you maybe pinpoint what im doing wrong?

iisakkirotko commented 3 weeks ago

Hey @mikegiann01!

I rebased the branch, so you could pull and try committing again. If that doesn't work, try upgrading flake8, or uninstalling and reinstalling pre-commit. (pre-commit clean, or pre-commit uninstall and pre-commit install)

mikegiann01 commented 2 weeks ago

Okay thank you for the response!! Sorry for the number of commits and the way i ve been using the platform , I am still trying to learn.

Στις Πέμ 18 Απρ 2024 στις 10:06 π.μ., ο/η Iisakki Rotko < @.***> έγραψε:

@.**** requested changes on this pull request.

Hi @mikegiann01 https://github.com/mikegiann01!

Looks like you're still having issues with pre-commit. It seems like the config file (.pre-commit-config.yaml) in your fork has been reset to a state from before some recent changes, which means that the code is being judged against different guidelines on your machine than online in our repository. I think this should be fixed with the following stes:

  • reset .pre-commit-config.yaml to the state it is in the master branch of our repo
  • run pre-commit uninstall && pre-commit install to install pre-commit

Other changes I'd like to see before merging this:

  • remove the newly added pre-commit config files ( solara/.pre-commit-config.yaml, etc.)
  • squash the current 6 commits down to one or two (using, for example, git rebase -i HEAD~6)

— Reply to this email directly, view it on GitHub https://github.com/widgetti/solara/pull/586#pullrequestreview-2008027640, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDVFFTWFTGZFP23FZBHVMEDY55WHNAVCNFSM6AAAAABF4PXF2KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBYGAZDONRUGA . You are receiving this because you were mentioned.Message ID: @.***>