fix: fade out was not restored on navigations from a thread or task

widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps

https://solara.dev

MIT License

1.6k stars 104 forks source link

fix: fade out was not restored on navigations from a thread or task #594

Closed maartenbreddels closed 3 weeks ago

maartenbreddels commented 3 weeks ago

A busy/idle pair of messages is only send when around a websocket message is handled in the main solara-server task. When the browser location changes, we fade out the main content, which we restore again when the idle message is received. But if we change the location from a thread or task, the busy and idle messages are not send, so the fade out is not restored, leaving the main content faded out.

To solve this we only fade out when the location changes and the kernel is busy.

render[bot] commented 3 weeks ago

Your Render PR Server URL is https://solara-stable-pr-594.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cobalmv109ks73csiqrg.