search

widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.6k stars 104 forks source link

fix: do not remove the solara cli tool when upgrading solara to 1.30 #608

Closed maartenbreddels closed 2 weeks ago

maartenbreddels commented 2 weeks ago

In solara version < 1.29, the cli tool was defined in the solara package. While now it is in the solara-server package.

It seems when pip upgrade to 1.30, it removes the solara package after installing solara-server (which just installed the cli tool), thereby removing the cli tool again. By also including the cli tool in the solara package, the cli tool will again be installed when it is installed after the older solara package.

pip does not seem to complain about this, but I wonder if we should do this, since I can also imagine that other systems may not like this. (e.g. pycafe?)

render[bot] commented 2 weeks ago

Your Render PR Server URL is https://solara-stable-pr-608.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cofs5j20si5c73f77m20.

maartenbreddels commented 2 weeks ago

We're afraid this will have unexpected consequences see #614