search

widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.62k stars 105 forks source link

fix: solara.display not working on some mimetypes in production mode #622

Closed iisakkirotko closed 2 weeks ago

iisakkirotko commented 2 weeks ago

These dependencies were aliased to an empty file to save on bundle size in https://github.com/widgetti/solara/commit/242d7e29bfeeb5ea53bdcfa113bb5caf4626dde9, but turn out to be necessary for the rendering of some mimetypes. Because the aliasing takes place during the minification step, development mode still worked, but running in production mode would show a javascript error.

Fixes https://github.com/widgetti/solara/issues/500.

render[bot] commented 2 weeks ago

Your Render PR Server URL is https://solara-stable-pr-622.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-conpq1mct0pc73dk05j0.

iisakkirotko commented 2 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite Graphite