search

widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.62k stars 105 forks source link

docs: remove `cancelled` arg from work function #74

Closed Jhsmit closed 1 year ago

Jhsmit commented 1 year ago

Assuming this is no longer needed

maartenbreddels commented 1 year ago

Thanks, always embarrassing when CI fails on an unrelated issue :)

maartenbreddels commented 1 year ago

Ah, this is because secrets (the username and password for oauth login are not available for PR from external repos)

Jhsmit commented 1 year ago

hmm isnt this setting supposed to fix that? Otherwise all external PRs would always fail image

maartenbreddels commented 1 year ago

Where do you see that setting?

Jhsmit commented 1 year ago

I think only I can see it as contributer of a PR But it looks like it reveals my secret rather than yours Still, wouldnt it make sense that since we are on widgetti/solara that the PR has access to GitHub secrets?

maartenbreddels commented 1 year ago

No, because that would allow anyone to add echo $SOME_SECRET to our CI, and steal our secrets :)

maartenbreddels commented 1 year ago

Sorry for all the noise, and thanks you for testing our CI pipeline for PR's :)