search

widgetti / solara

A Pure Python, React-style Framework for Scaling Your Jupyter and Web Apps
https://solara.dev
MIT License
1.91k stars 141 forks source link

Docs update cross filter dataframe #840

Closed lizzy985 closed 1 week ago

maartenbreddels commented 2 weeks ago

@lizzy985 the code quality workflow error gives a hint on what you need to fix.

lizzy985 commented 2 weeks ago

@lizzy985 the code quality workflow error gives a hint on what you need to fix.

Thank you! I will do a new pull request. But I have a confusion.

I initially remove solara.column. When I did rebase before I committed, there is a conflict. It seems that someone has correct the code before me and you approved his pull request (Am I correct?). When I did a merge, I though what you approved should be good, so I choose to accept what you approved. But apparently, it still should remove solara.column as you told me.

I found all of my recently pull request have same code quality error because of linked_views.py code quality error. I have updated my old pull request for linked_views.py (update code in linked_views.py #834 ). I want to ask if this pull request approved, other pull requests' issues will automatically resolved?

maartenbreddels commented 2 weeks ago

There is not need to do new pull requests. If you rebase on master, you can indeed get conflicts, which you need to solve. With a bit of practice you get used to it.

The approval of the other PR is indepandent of this one. Make sure that if you make a new branch, that you always start from master, and not the previous branch. I hope that helps.