search

widmogrod / zf2-assetic-module

Zend Framework module for Assetic
146 stars 62 forks source link

Prepare for ZF3, ServiceLocatorAwareInterface is deprecated #143

Closed tylkomat closed 8 years ago

tylkomat commented 8 years ago

PHP Deprecated: ServiceLocatorAwareInterface is deprecated and will be removed in version 3.0, along with the ServiceLocatorAwareInitializer. Please update your class AsseticBundle\FilterManager to remove the implementation, and start injecting your dependencies via factory instead.

PHP Deprecated: ServiceLocatorAwareInterface is deprecated and will be removed in version 3.0, along with the ServiceLocatorAwareInitializer. Please update your class AsseticBundle\Controller\ConsoleController to remove the implementation, and start injecting your dependencies via factory instead.

widmogrod commented 8 years ago

@tylkomat thanks for noticing that. If this feature would be useful for you, then probably will be useful for someone else in community. Unfortunately I don't have time to do this, but I would gladly accept your contribution to this project :)

Saeven commented 8 years ago

Hey @widmogrod! ZF3 is out now, and seems the eventManager has broken things. You open to a PR to get it up to par?

widmogrod commented 8 years ago

@Saeven hi, I will gladly accept any PR that pass tests :)

Saeven commented 8 years ago

Thanks @widmogrod ! https://github.com/widmogrod/zf2-assetic-module/pull/146

Tried on a local zf3 project, seems to work well. Tests pass. Added zend-version to maintain ZF2 functionality. Only very minor modifications.

widmogrod commented 8 years ago

@Saeven Thank you for your work!

Saeven commented 8 years ago

No probs, the goal was just to support the event manager. I'll keep plugging to do all the new factory work.

tylkomat commented 8 years ago

@Saeven was already done see #147.